Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

[Idea] Make query filter optional when returning credentials #488

Closed
kirahsapong opened this issue May 25, 2023 · 2 comments
Closed

[Idea] Make query filter optional when returning credentials #488

kirahsapong opened this issue May 25, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kirahsapong
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When requesting credentials, a query param of issuer, subject or schema is required and the response is filtered accordingly.

Describe the solution you'd like
Would be great to make this query param optional, and return all credentials in the absence of a filter.

Describe alternatives you've considered
Currently traversing all issuer DIDs stored in the db and requesting credentials by issuer in order to get all credentials stored in the db

@kirahsapong kirahsapong added the enhancement New feature or request label May 25, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in SSI May 25, 2023
@decentralgabe decentralgabe added this to the Milestone v0.0 milestone May 25, 2023
@decentralgabe decentralgabe moved this from 🆕 New to 🔖 Up Next in SSI May 25, 2023
@decentralgabe
Copy link
Contributor

fix is in #489

@decentralgabe decentralgabe moved this from 🔖 Up Next to 👀 In review in SSI Jun 1, 2023
@nitro-neal
Copy link
Contributor

#489 is merged in

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in SSI Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants