Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

List Credentials without params #489

Merged
merged 11 commits into from
Jun 6, 2023
Merged

List Credentials without params #489

merged 11 commits into from
Jun 6, 2023

Conversation

nitro-neal
Copy link
Contributor

This change allows you to list all credentials without a query param. The query params are now optional.

image

pkg/server/router/credential.go Outdated Show resolved Hide resolved
pkg/server/server_credential_test.go Outdated Show resolved Hide resolved
pkg/service/credential/service.go Outdated Show resolved Hide resolved
pkg/service/credential/storage.go Show resolved Hide resolved
pkg/service/credential/storage.go Show resolved Hide resolved
pkg/service/credential/storage.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #489 (e14646c) into main (e20946d) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   20.90%   20.71%   -0.19%     
==========================================
  Files          49       49              
  Lines        5837     5890      +53     
==========================================
  Hits         1220     1220              
- Misses       4392     4445      +53     
  Partials      225      225              
Impacted Files Coverage Δ
pkg/server/router/credential.go 3.29% <0.00%> (-0.19%) ⬇️
pkg/service/credential/service.go 0.00% <0.00%> (ø)
pkg/service/credential/storage.go 1.60% <0.00%> (-0.08%) ⬇️

@nitro-neal nitro-neal merged commit a57092c into main Jun 6, 2023
@nitro-neal nitro-neal deleted the list-creds branch June 6, 2023 19:25
tlongwell-block pushed a commit that referenced this pull request Jun 8, 2023
* list creds

* Apply suggestions from code review

Co-authored-by: Andres Uribe <auribe@tbd.email>

* update spec

* adding info instead of warn

* fix spec

* update log

* updating to listcredentials

---------

Co-authored-by: Gabe <7622243+decentralgabe@users.noreply.github.com>
Co-authored-by: Andres Uribe <auribe@tbd.email>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants