This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
[OSE-167] Scaffolding for /v1/operations #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
| db *storage.BoltDB | ||
| } | ||
|
|
||
| func (b BoltOperationStorage) StoreOperation(op StoredOperation) error { |
There was a problem hiding this comment.
is this PR intended to be a draft? or do you aim to merge with these unimplemented?
There was a problem hiding this comment.
I intend to merge with these unimplemented. They will be implemented in subsequent PRs. Just trying to keep the surface area small.
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 26.16% 26.37% +0.21%
==========================================
Files 20 21 +1
Lines 1594 1623 +29
==========================================
+ Hits 417 428 +11
- Misses 1106 1123 +17
- Partials 71 72 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
decentralgabe
approved these changes
Nov 14, 2022
andresuribe87
added a commit
to andresuribe87/ssi-service
that referenced
this pull request
Nov 14, 2022
* The simplest scaffolding possible * rename Co-authored-by: Gabe <gcohen@squareup.com>
andresuribe87
added a commit
that referenced
this pull request
Nov 15, 2022
* Initial create, delete, get for submissions * Basic tests for the router * Added the rest of the scaffolding * Added List and Review * Removed the delete method * Simplified for scaffolding * spec * zero structs * Consolidate under the same API * mage spec * Minor updates * [OSE-167] Scaffolding for /v1/operations (#172) * The simplest scaffolding possible * rename Co-authored-by: Gabe <gcohen@squareup.com> * Fix lint and compilation * PR fixes * rename * regen * spec * Removed unused config * reviews Co-authored-by: Gabe <gcohen@squareup.com>
andresuribe87
added a commit
that referenced
this pull request
Nov 29, 2022
* Initial create, delete, get for submissions * Basic tests for the router * Added the rest of the scaffolding * Added List and Review * Removed the delete method * Simplified for scaffolding * spec * zero structs * Consolidate under the same API * mage spec * Minor updates * [OSE-167] Scaffolding for /v1/operations (#172) * The simplest scaffolding possible * rename Co-authored-by: Gabe <gcohen@squareup.com> * Fix lint and compilation * PR fixes * rename * regen * Removed unused config * The simplest scaffolding possible * Implemented ops storage * Simple impl * Submission implementation with test * Swagger spec * Neatly wrapping up * Upgrade mod * minor improvements * PR comments. * PR comments. Co-authored-by: Gabe <gcohen@squareup.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the boilerplate needed to support the operation api with the get/list/cancel actions.