fix: simplify json format/validation action #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamchau
requested review from
michaelneale,
mistermoe,
jiyoonie9,
KendallWeihe,
kirahsapong,
diehuxx,
decentralgabe and
angiejones
as code owners
lamchau
force-pushed
the
lamchau/fix-workflow
branch
6 times, most recently
from
4ba22dd
to
2c0e405
Compare
lamchau
changed the title
lamchau
force-pushed
the
lamchau/fix-workflow
branch
2 times, most recently
from
f776ed2
to
e7eed13
Compare
lamchau
force-pushed
the
lamchau/fix-workflow
branch
from
e7eed13
to
1bfd7bd
Compare
jiyoonie9
approved these changes
Aug 29, 2024
nitro-neal
approved these changes
Sep 3, 2024
KendallWeihe
reviewed
Sep 3, 2024
Comment on lines
-38
to
43
| no_errors_found=false | ||
| has_errors=true | ||
| fi | ||
| done | ||
|
|
||
| if [ "$no_errors_found" = true ]; then | ||
| echo "[success] All JSON files are valid" | ||
| else | ||
| if [ "$has_errors" = true ]; then | ||
| exit 1 |
There was a problem hiding this comment.
maybe just exit 1 right away instead of assigning to a variable and then reading afterwards?
There was a problem hiding this comment.
we could! if the user had 3 malformed files then they'd only see one at a time.
this felt more "ergonomic" to show all the files so potentially it (just lint) could be fixed without having to run it multiple times.
open to either approach!
There was a problem hiding this comment.
i'm for showing all the files that fail lint at once
There was a problem hiding this comment.
yeah nice, that's better!
KendallWeihe
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the GitHub Actions workflow in PR #364 😅. This update also fixes an issue where
justwas missing in thehermitsetup, which the previous workflow didn’t catch.Since
just formatinherently includesjust lint, we can just consolidate that into a single action.This change removes much of the automation introduced in the earlier PR, placing the responsibility on the author to ensure well-formed JSON is committed to the repository. The original intent was to automate formatting when directly modifying JSON files via the GitHub web interface (bypassing the
pre-commithook). However, after reconsideration, this is likely not the most common workflow and might not be something we should encourage anyway.Note: We still only check
hosted/*.jsonwhich are the only assets published to tbdex.dev.