Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily to address:
which surfaced in this PR.
npm audit fix
proposed solution is to downgrade to c8v5.0.2
released on June 23, 2019:An attempt was made to manually override the version of
semver
tov7.5.3
which fixes the vulnerability but due to apparent bugs innpm
's overrides feature, it ignores the specified overrides. Over a dozen additional permutations were attempted to override the c8 dependencies that introduce this vulnerability (instanbul-lib-report
,make-dir
), but those overrides were ignored bynpm
as well. While not this specific issue, there are multiple reported bugs (4942, 4834, 5850) with NPM's overrides feature which have not been addressed in over a year.Given that the issue will continue to block future PRs due to the failing security audit and lack of certainty about when NPM overrides will work properly, the workaround was to patch
package-lock.json
until new versions of thec8
andinstanbul-lib-report
are published. Thesemver
andmake-dir
projects were patched in the past 48 hours.Issue #135 was created to track when we can stop manually patching
package-lock.json
.This PR also opportunistically improves the ESLint rules for
switch
to indentcase:
statements