Code

Node 14#1050

Code

Merged

Stephen-ONeil merged 34 commits intomasterTBS-EACPD/infobase:masterfrom node-14TBS-EACPD/infobase:node-14Copy head branch name to clipboardApr 30, 2021

+4,436-1,950

Commits

Commits on Apr 28, 2021

• Set node 14 as the expected node version for development of the project and deployment of the google cloud functions

  Stephen-ONeil

  committed
  54efa2f

  Copy full SHA for 54efa2f

• Re-run npm install for each package.json, newer npm has minor package-lock.json differences

  Stephen-ONeil

  committed
  702d2ab

  Copy full SHA for 702d2ab

• npm audits all around, may as well

  Stephen-ONeil

  committed
  92ae2c3

  Copy full SHA for 92ae2c3

• Covert /server to ecma modules, bunch of linting in the process. Drop transpillation and babel from the project (note: Jest doesn't support ecma modules well yet, still requires babel as a peer dep…

  Show description for d695a84
  Stephen-ONeil

  committed
  d695a84

  Copy full SHA for d695a84

• Update common_node_scripts, fixing some CommonJS to esModule transformation bugs (might not have been worth the conversion, but for now I'm leaning towards consistency)

  Stephen-ONeil

  committed
  e77c257

  Copy full SHA for e77c257

• Rename prettier.config.js to prettier.config.cjs, to help with hinting that it's a CommonJS module

  Stephen-ONeil

  committed
  e1ff348

  Copy full SHA for e1ff348

• Drop references to server transpiled builds from CircleCI config

  Stephen-ONeil

  committed
  9275cae

  Copy full SHA for 9275cae

• Update email_backend to natively use esModules. Tweak email_backend and server babel set up to include babel-plugin-transform-import-meta

  Stephen-ONeil

  committed
  a0fddec

  Copy full SHA for a0fddec

• Revert npm audit's nivo upgrades. More undocument API changes in there, not something I want to tangle with in this branch

  Stephen-ONeil

  committed
  a4f1d96

  Copy full SHA for a4f1d96

Commits on Apr 29, 2021

• Update dockerfiles to node 14. Use new images (v1.4) in CI

  Stephen-ONeil

  committed
  c92597a

  Copy full SHA for c92597a

• Oops, npm install in /server to sync package.json and package-lock.json

  Stephen-ONeil

  committed
  7cc6a17

  Copy full SHA for 7cc6a17

• Fix docker image tags

  Stephen-ONeil

  committed
  2a17da8

  Copy full SHA for 2a17da8

• Try medium+ resource class for client build job

  Stephen-ONeil

  committed
  651e631

  Copy full SHA for 651e631

• Fix client build_all.sh's ability to set node's --max-old-space-size flag for prod builds... because, after everything, turns out that was STILL broken

  Stephen-ONeil

  committed
  1f5a267

  Copy full SHA for 1f5a267

• Try higher max-old-space-size for CI builds

  Stephen-ONeil

  committed
  919c9a4

  Copy full SHA for 919c9a4

• Ah, re-add server/.babelrc to files persisted after CI build job

  Stephen-ONeil

  committed
  4ee0991

  Copy full SHA for 4ee0991

• Fix bad find-and-replace in merge_coverage_reports.js

  Stephen-ONeil

  committed
  148b6e9

  Copy full SHA for 148b6e9

• Fix email_backend extract_data.sh for node 14/esModules

  Stephen-ONeil

  committed
  fab7a63

  Copy full SHA for fab7a63

• Remove old babel-node from server prod_deploy_data.sh

  Stephen-ONeil

  committed
  53ff3ca

  Copy full SHA for 53ff3ca

Commits on Apr 30, 2021

• Bring back transpiled builds for /server and /email_backend cloud function deploys

  Stephen-ONeil

  committed
  24dd399

  Copy full SHA for 24dd399

• chmod email_backend and server build.sh scripts, minor tangential tweak in client/.eslintrc.json

  Stephen-ONeil

  committed
  3b8d108

  Copy full SHA for 3b8d108

• Call babel via npx in email_backend and server build.sh, to use bin from local node_modules rather than requiring it to be installed globally

  Stephen-ONeil

  committed
  11dbd0a

  Copy full SHA for 11dbd0a

• Ugh, ok, fine. Add prod_build scripts to server and email_backend package.json. Didn't want to, since they're really only needed for the deploy scripts (which aren't run through package.json), but …

  Show description for 1dde1c4
  Stephen-ONeil

  committed
  1dde1c4

  Copy full SHA for 1dde1c4

• Go back to using transpiled_build for checksumming in CI deploy_server step, so that the function will redeploy on transiplation config change

  Stephen-ONeil

  committed
  9923417

  Copy full SHA for 9923417

• Duh, late-working brain, the deploy server job uses a slim google cloud sdk image, shouldn't be trying to run babel in there. Lift server transpile up in to the main build job, persist to the works…

  Show description for 439b8d1
  Stephen-ONeil

  committed
  439b8d1

  Copy full SHA for 439b8d1

• Cleanup server and email_backend babel configs and packages slightly, plugin-transform-modules-commonjs is part of preset-env by default

  Stephen-ONeil

  committed
  7f6f2fd

  Copy full SHA for 7f6f2fd

• Hack alert, toss a package.json in to the GCF transpiled_build dirs to declare that the modules are CommonJS rather than esModules

  Stephen-ONeil

  committed
  63c56be

  Copy full SHA for 63c56be

• Fix server/src/index.js, want a named export app, not a default export with the property app...

  Stephen-ONeil

  committed
  d75a504

  Copy full SHA for d75a504

• Move server and email_backend build scripts out of package.json and back in to bash scripts alongside the other deploy-specific scripts for those projects

  Stephen-ONeil

  committed
  c9c098f

  Copy full SHA for c9c098f

• Add "import/extensions": ["error", "always"] to root eslint config, lint for it (and catch some other misc unlinted lines in client/src)

  Stephen-ONeil

  committed
  80bc171

  Copy full SHA for 80bc171

• For preservation, an attempt to port client build code to esModules. See PR 1050 for notes on what prevents this from being an option

  Stephen-ONeil

  committed
  2c4b038

  Copy full SHA for 2c4b038

• Revert "For preservation, an attempt to port client build code to esModules. See PR 1050 for notes on what prevents this from being an option"

  Show description for bcf98f1
  Stephen-ONeil

  committed
  bcf98f1

  Copy full SHA for bcf98f1

• Small tweaks to eslint configs in node script sub directories of /client

  Stephen-ONeil

  committed
  76c6226

  Copy full SHA for 76c6226

• Bring back CI build job caching for transpiled /server code

  Stephen-ONeil

  committed
  eb9dfd9

  Copy full SHA for eb9dfd9