Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Selection Tools #110

Open
TBye101 opened this issue Jan 13, 2019 · 9 comments
Open

Job Selection Tools #110

TBye101 opened this issue Jan 13, 2019 · 9 comments

Comments

@TBye101
Copy link
Owner

TBye101 commented Jan 13, 2019

Clicking on one command type doesn't unselected the others

@ABuonanni
Copy link
Collaborator

For what I can see this behaviour isn't implement at all. So this is not a bug to find and fix but a feature to implement, right?

@TBye101
Copy link
Owner Author

TBye101 commented Apr 9, 2019

Yeah, not sure why I marked this as a bug. Must've been late or something.

@TBye101 TBye101 added enhancement and removed bug labels Apr 9, 2019
@ABuonanni ABuonanni self-assigned this Apr 10, 2019
@ABuonanni
Copy link
Collaborator

I'm looking at this issued and I was thinking that action buttons (Chop, Mine and TillDirt) should have a public boolean property called like "IsSelected" or "HasSelectedAspect" that the InGameGUI can use to set its buttons appeareance. The property setter code will choose the right texture for the button based on the value of InGameGUI's Selected property. Now this behaviour should be applied to all three buttons and I were wondering wheter was the case to create a new class (called something like ActionButton, to hold all common action buttons behaviour) to implements this in or to implement it in the MonoButton class (but I don't like this second option as much as the first). What do you say?

@TBye101
Copy link
Owner Author

TBye101 commented Apr 14, 2019 via email

@ABuonanni
Copy link
Collaborator

I like the idea. I'm gonna implement a class that extends MonoButton and a class, let say "ActionButtonsManager", that handles only having one togglable button active at a time.

@TBye101
Copy link
Owner Author

TBye101 commented Apr 15, 2019 via email

@ABuonanni
Copy link
Collaborator

Ok, I'll do. Thanks.

@ABuonanni
Copy link
Collaborator

I'm resuming working on this issue. Is still Crafting the branch to work on?
Thanks.

@TBye101
Copy link
Owner Author

TBye101 commented May 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants