Introduce passive mode #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wheatley.ts
Outdated
| @@ -948,6 +956,9 @@ export class Wheatley { | |||
| // command edit/deletion | |||
|
|
|||
| register_text_command(trigger: Discord.Message, command: TextBasedCommand, deletable = true) { | |||
| if (this.passive) { | |||
There was a problem hiding this comment.
I am not sure this is the right place to do this. Maybe instead this could be checked in handle_text_command/handle_slash_comand? It may also be important to do this in on_interaction, depending on goals.
There was a problem hiding this comment.
If we do this not here but later on, wouldn't that mean that the commands are still registered though? I don't think we want it to fill the list of slash commands with inoperational duplicates?
There was a problem hiding this comment.
OK, I guess you meant to only do this for text commands? I'll update the PR.
There was a problem hiding this comment.
Talked on discord, thanks for resolving
michael-kenzel
force-pushed
the
passive-mode
branch
from
b87c34e
to
582f69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In passive mode, Wheatley will not advertise or react to commands, and only load components that are marked as passive. This is to allow additional secondary instances of the bot to coexist with a running primary instance on the same server without interference, e.g., for testing new features.