Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace12679 #12730

Closed
wants to merge 4 commits into from
Closed

Whitespace12679 #12730

wants to merge 4 commits into from

Conversation

ArunErram
Copy link

@ArunErram ArunErram commented Feb 6, 2024

Fixes #12679

Outline of Solution

Copy link

github-actions bot commented Feb 6, 2024

Hi @ArunErram, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@weiquu
Copy link
Contributor

weiquu commented Feb 6, 2024

Hi @ArunErram, do take a look at the failing tests, and let us know if you face any issues

@ArunErram
Copy link
Author

ArunErram commented Feb 7, 2024

@weiquu , I'll check the test cases, these just a draft PR as you said to raise , and as I informed previously wasn't able to login as student or instructor to check the modification done in code , so can you help me with these login

@ArunErram ArunErram closed this Feb 7, 2024
@ArunErram ArunErram reopened this Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Hi @ArunErram, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@weiquu
Copy link
Contributor

weiquu commented Feb 9, 2024

@weiquu , I'll check the test cases, these just a draft PR as you said to raise , and as I informed previously wasn't able to login as student or instructor to check the modification done in code , so can you help me with these login

Hi @ArunErram, I've replied to your discussion post here. Let's continue the conversation there

@cedricongjh cedricongjh added the s.Ongoing The PR is being worked on by the author(s) label Feb 19, 2024
@cedricongjh
Copy link
Contributor

closing due to inactivity, do reopen the PR if you continue work on the issue

@cedricongjh cedricongjh closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying feedback session: Name for copied session should not be whitespace
4 participants