-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GHA for compilation and testing #41
Conversation
There is no "make check", just the gsw_check executable. It currently returns zero regardless of whether it fails or succeeds. Making it return 1 (for example) on failure requires changing if (gsw_error_flag)
printf("\nYour installation of the Gibbs SeaWater (GSW) "
"Oceanographic Toolbox has errors !\n");
else to if (gsw_error_flag)
{
printf("\nYour installation of the Gibbs SeaWater (GSW) "
"Oceanographic Toolbox has errors !\n");
return (1);
}
else in gsw_check_functions.c. |
I can make the changes later this week. Working on setting the compiler config up first. |
I took a crack at having a non zero exit status in #43 If you want just cherrypick that code and stick it in this PR. |
It is late for me and I'm on my phone only now. It is OK to merge your PR and I'll rebase this PR tomorrow. Thnaks! |
For Linux/OSX we need to run "make -f Makefile", not just plain "make", so that Makefile will be used instead of GNUmakefile. Or remove (or move) GNUmakefile, which is obsolete; it has features specific to its origin at SIO. It shows how to do some things that someone might want, so instead of deleting it, perhaps it should be moved to "GNUmakefile.example". |
7e083e1
to
2522f55
Compare
6418686
to
ceed448
Compare
@efiring I may need some help on how you test this locally. We do not have a
make check
, right?