feat(launchpad): add contract and deps #1315
Conversation
WaDadidou
commented
Oct 18, 2024
•
WaDadidou
commented
- Add workspace and root Cargo.toml
- Add a network feature
- Add nft-launchpad contract
- Add nft-tr721 contract
- Add scripts to optimize, deploy and instantiate nft-launchpad contract, and optimize and deploy nft-tr721 contract
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
requested review from
n0izn0iz,
hthieu1110,
omarsy,
Villaquiranm and
MikaelVallenet
n0izn0iz
changed the title
WaDadidou
changed the title
WaDadidou
force-pushed
the
feat-nft-launchpad-contract
branch
from
4389e54
to
975e22d
Compare
| #[cw_serde] | ||
| pub struct Config { | ||
| pub name: String, | ||
| pub nft_code_id: Option<u64>, |
There was a problem hiding this comment.
why make it an Option?
| pub nft_code_id: Option<u64>, | |
| pub nft_code_id: u64, |
There was a problem hiding this comment.
We can use nft-launchpad without nft-tr721. Only deploy_collection will not work.
Same for admin, we don't need the admin to use submit_collection or update_merkle_root
There was a problem hiding this comment.
when do we want only parts of the functions working?
There was a problem hiding this comment.
I don't understand.
We don't need tr721 or authority to send CollectionProject data onchain.
The users can create and complete collections.
The admin can deploy
There was a problem hiding this comment.
yes okay, but do we really want to allow to instantiate the launchpad with no underlying cw721 implem or no admin?
when does it make sense? do you have a usecase?
I think this just adds uneeded complexity and corner cases
There was a problem hiding this comment.
For me, if we don't need it to execute things, it should be not mandatory (dummy style)
But it's not a "smartcontract vision".
I can counter my own argument with this: https://github.com/TERITORI/teritori-dapp/blob/feat-nft-launchpad-contract/rust/cw-contracts/cw721-membership/src/contract.rs#L90
All Config fields are mandatory, but not necessary used in all the functions of this contract.
I have no use case, I'll make them mandatory ^^
|
|
||
| #[cw_serde] | ||
| #[derive(Default)] | ||
| pub struct Collection { |
There was a problem hiding this comment.
| pub struct Collection { | |
| pub struct CollectionProject { |
to disambiguate with the actual Collection
There was a problem hiding this comment.
Why not just LaunchpadCollection ?
There was a problem hiding this comment.
because we're already in the nft-launchpad context
There was a problem hiding this comment.
Remove unused supported_networks Set ConfigChanges all fields optional Rename struct Collection Remove unused CollectionState Remove comments
