Add CTakeDamageInfo natives to use with TakeDamage #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CBaseEntity.TakeDamageInfo native - Added signature to gamedata Add CTakeDamageInfo.Set native Add GetGlobalDamageInfo native Imported Init and Set CTakeDamage funcs from SDK Fix CTakeDamageInfo.AddDamageType missing parameter Fix some CTakeDamageInfo natives not returning immediately after erroring
|
|
Kenzzer
requested changes
Dec 28, 2023
Kenzzer
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds natives for creating and applying custom CTakeDamageInfo parameters to entities using
CBaseEntity::TakeDamage(). Plugins can use theGetGlobalDamageInfonative to specify custom parameters for use in TakeDamage.CBaseEntity::TakeDamagewas used overCBaseEntity::OnTakeDamagebecause it checks for damage filters and applies damage scaling before OnTakeDamage is called. In addition, not only is it used across the SDK, it's the recommended way of dealing damage to entities anyways. On the other hand,SDKHooks_OnTakeDamagebypasses that and callsCBaseEntity::OnTakeDamagedirectly.Some other miscellaneous changes:
CBaseEntity::TakeDamagesignature to gamedataCTakeDamageInfofuncs from SDKCTakeDamageInfo.Set/AddDamageTypenatives missing a parameter (reported by @Mikusch)CTakeDamageInfonatives not returning immediately after erroring