Make usagePropertiesAutoUpdateMode configurable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
Danesz
approved these changes
Nov 20, 2023
| @@ -11,6 +11,7 @@ public class ComScoreConfiguration { | |||
| public let publisherId: String | |||
| public let applicationName: String | |||
| public var userConsent: ComScoreUserConsent | |||
| public var usagePropertiesAutoUpdateMode: ComscoreUsagePropertiesAutoUpdateMode | |||
There was a problem hiding this comment.
Maybe I don't see the complete picture, but:
if this value can't change (e.g. if we change it, but the underlying analytics plugin is already initialized with the old value (and it never updates)) consider making it a let, or we need to make sure the underlying code takes into account the updated value
| @@ -27,10 +28,11 @@ public class ComScoreConfiguration { | |||
| - adIdProcessor: Provide a closure if you want to customize how the ad id is determined. By default, the integration uses Ad.id. | |||
| @@ -14,6 +14,24 @@ public enum ComScoreUserConsent: String { | |||
| case unknown = "-1" | |||
| } | |||
|
|
|||
| @frozen | |||
| public enum ComscoreUsagePropertiesAutoUpdateMode: String { | |||
| case foregroundOnly | |||
There was a problem hiding this comment.
Maybe add a basic doc about these properties. (as this is a public API)
| func toComscore() -> SCORUsagePropertiesAutoUpdateMode { | ||
| switch self { | ||
| case .foregroundOnly: | ||
| return .foregroundOnly |
There was a problem hiding this comment.
nit-pick: (maybe it is for me personally), but I think in this scenario maybe it would make it a bit more readable, if we use the class name too in the return?
case .foregroundOnly:
return SCORUsagePropertiesAutoUpdateMode.foregroundOnly
Danesz
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary change for react-native-theoplayer-analytics PR for Comscore