158 vehicle location information #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation available at: |
|
@SorenSpicknall @e-lo can you tell me what I’m doing wrong here. |
The error you're seeing isn't your fault - a file used for validation was deleted in a previous PR, and the relevant test just didn't run after that until you drafted and submitted these changes. I've opened #165 to address the missing file. |
botanize
requested changes
Oct 4, 2023
… location_ping_id field
…location_ping_id field
KatrinaMKaiser
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Learned from @SorenSpicknall today that you'll also need to update the sample CSVs
|
Data Validation Report
|
|
Data Validation Report
|
1 similar comment
|
Data Validation Report
|
botanize
approved these changes
Oct 12, 2023
KatrinaMKaiser
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #158 adding location_ping_id fields to passenger_events and fare_transactions.