Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation challenges (#187) #191

Conversation

Danishswag
Copy link

Fixes #187

Bugs

  • Added service_date to trips_performed foreign key in fare_transactions, passenger_events, stop_visits, vehicle_locations
  • Changed train_car to train_cars in foreign key in passenger_events
  • Pointed passenger_events.trip_stop_sequence in passenger_events to stop_visits.trip_stop_sequence in the stop_visits foreign key
  • Removed foreign key to stop_times

Styles

  • Modified enums for devices to start with an uppercase letter
  • Changed all capacity columns to capacity_xxxx

@Danishswag
Copy link
Author

Not entirely sure why it failed, looks like error is Error: Unhandled error: HttpError: Resource not accessible by integration in validate-samples.

I did update some of the CSVs in samples/template to the new column names, happy to make any other changes if necessary

@e-lo
Copy link
Contributor

e-lo commented Dec 1, 2023

@Danishswag in order to run the CI activities you need to do it form a branch of TIDES-transit/TIDES instead of your local fork. You should be able to do this via quick git push to origin from your local fork: git push origin 187-implementation challenges

@Danishswag
Copy link
Author

Unfortunately that didn't work for me, I tried setting my remote to github.com/Tides-transit/TIDES, and when I ran

git push origin 187-implementation challenges I got:

remote: Permission to TIDES-transit/TIDES.git denied to Danishswag.
fatal: unable to access 'https://github.com/TIDES-transit/TIDES/': The requested URL returned error: 403

I think you'll need to add me to the repo/organization with more permissions than I currently have

@Danishswag Danishswag closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛💻 – Implementation Challenges: Foreign Key Issues and Style Inconsistencies
2 participants