Feature/modular adapters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/segregate api and plugins
akshay-ap
force-pushed
the
feature/modular-adapters
branch
from
ea96413 to
3f7531d
Compare
ghareeb-falazi
requested changes
Mar 9, 2022
app/src/main/java/blockchains/iaas/uni/stuttgart/de/adaptation/BlockchainAdapterFactory.java
Outdated
Show resolved
Hide resolved
| * This ensures that the SDK is able to find the orderer and network peers. | ||
| */ | ||
| @Disabled | ||
| class FabricAdapterTest { |
There was a problem hiding this comment.
Same comment as for Ethereum
.../java/blockchains/iaas/uni/stuttgart/de/adaptation/utils/BooleanExpressionEvaluatorTest.java
Outdated
Show resolved
Hide resolved
.../java/blockchains/iaas/uni/stuttgart/de/adaptation/utils/JsonSchemaToJavaTypeMapperTest.java
Outdated
Show resolved
Hide resolved
test/java/blockchains/iaas/uni/stuttgart/de/adaptation/utils/PoWConfidenceCalculatorTest.java
Outdated
Show resolved
Hide resolved
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ConnectionProfileManagerTest { | ||
| // private void assertProfiles(ConnectionProfilesManager manager) { |
There was a problem hiding this comment.
Don't forget to provide alternative tests for this class
…ss, use finally block
…ion-profile-use Update object mapper at runtime
ghareeb-falazi
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.