Fix OOB read bug and change code style in NRSSR sanitizer #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead for the server. Shouldn't be exploitable at all, but it should still be fixed.
tremwil
changed the title
tremwil
changed the title
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where the maximum size to wcsnlen_s was passed in bytes instead of
wchar_t.I don't know how this one slipped past when I reviewed my code, it's a pretty silly mistake. If not patched it can lead to an OOB read that could be used to trigger an access violation in very specific circumstances.
Edit: Saw your comment in my first pull request and edited the code style to match the rest of the project.