fix @ArchIgnore not being fully respected by JUnit 4 support
#1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecholeric
force-pushed
the
fix-junit-4-support-not-respecting-ArchIgnore-on-child-class
branch
3 times, most recently
from
d312d8f to
be3f3be
Compare
hankem
approved these changes
Apr 3, 2024
.../junit4/src/test/java/com/tngtech/archunit/junit/internal/ArchUnitRunnerRunsMethodsTest.java
Outdated
Show resolved
Hide resolved
In the case of inheritance we were looking at the wrong class for an `@ArchIgnore`. I.e. rule declarations in base classes would only be ignored if the base class was annotated with `@ArchIgnore`, not the actual class. We now check the actual class for the annotation instead. If the base class is annotated with `@ArchIgnore` we ignore it for now, since this is a corner case and one could argue for both, either ignoring all subclasses or not ignoring subclasses. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
codecholeric
force-pushed
the
fix-junit-4-support-not-respecting-ArchIgnore-on-child-class
branch
from
fb2ce54 to
ce6a69d
Compare
codecholeric
deleted the
fix-junit-4-support-not-respecting-ArchIgnore-on-child-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of inheritance we were looking at the wrong class for an
@ArchIgnore. I.e. rule declarations in base classes would only be ignored if the base class was annotated with@ArchIgnore, not the actual class. We now check the actual class for the annotation instead. If the base class is annotated with@ArchIgnorewe ignore it for now, since this is a corner case and one could argue for both, either ignoring all subclasses or not ignoring subclasses.