fix PlantUmlArchCondition.Configuration not accessible warning
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the contrary to the Java compiler the Kotlin compiler emits a warning that `PlantUmlArchCondition.Configuration` as the parameter type of `PlantUmlArchCondition.adhereToPlantUmlDiagram()` is not accessible (because it is package private). Since in the end the pattern used here is a little inconsistent to other places anyway we change this now to be a publicly accessible class. The current construct was a little strange, either it needs to be a generic interface, freely extensible, but then there does not seem to be a reason to hide it from the user. Or we want to limit the possibilities, but then we might as well use a concrete class. As an additional benefit (since we will break the API anyway with release 1.0) we can now define the factory methods directly on the parameter type removing one indirection. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric
force-pushed
the
make-PlantUmlArchCondition.Configuration-accessible
branch
from
2ab6e6b to
e1680a5
Compare
codecholeric
deleted the
make-PlantUmlArchCondition.Configuration-accessible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the contrary to the Java compiler the Kotlin compiler emits a warning that
PlantUmlArchCondition.Configurationas the parameter type ofPlantUmlArchCondition.adhereToPlantUmlDiagram()is not accessible (because it is package private). Since in the end the pattern used here is a little inconsistent to other places anyway we change this now to be a publicly accessible class.This will be a breaking change, because it relocates the factory methods from
PlantUmlArchCondition.ConfigurationstoPlantUmlArchCondition.Configuration.Resolves: #888