Implementing ability to pass information about test method to a data provider method

[barancev]

No description provided.

[aaschmid]

Hi @barancev,

nice idea. May I ask what you want to do with it? Just for my curiosity and use cases for documentation :-)

Cheers,
Andreas

[barancev]

This feature allows to create "universal data providers" that can be configured via annotations assigned to test methods, for example:

@Test
@UseDataProvider("loadFromFile")
@TestDataFile("file1.dat")
public void test1() { ... }

@Test
@UseDataProvider("loadFromFile")
@TestDataFile("file2.dat")
public void test2() { ... }

@DataProvider
public static Object[][] loadFromFile(FrameworkMethod testMethod) throws IOException {
  File testDataFile = new File(testMethod.getAnnotation(TestDataFile.class).value());
  // load data from the specified file and return it
}

[barancev]

Yes, passing null to call as static is correct, my bad.

[aaschmid]

Yes, passing null to call as static is correct, my bad.

Can you change this directly in the pull request by adding just another commit to your branch from which the pull request is generated?

And an acceptance test (= example) using the new feature in com.tngtech.test.java.junit.dataprovider.DataProviderJavaAcceptanceTest would be great (but I can do it on the weekend as well as I know understand the use case ;-) )

Thanks a lot for contributing!

[barancev]

Will do both on the weekend

[aaschmid]

Great, looking forward to it ... thanks a lot!

[coveralls]

Coverage increased (+0.01%) when pulling ddf8ac9 on barancev:master into 0f40ab2 on TNG:master.

[barancev]

Done

[aaschmid]

Thank you very much, I have just added another test and refactored the code a bit. Also added release notes and example as you may see ...

[barancev]

Thanks! Also remove it from the TBD section of the README

[aaschmid]

But it's not release for now ... I will change the section as soon as I will release a new version, ok? Hopefully at the end of the week, will that be ok for you?

[barancev]

OK

[aaschmid]

Hi @barancev,

I know that your PR request is a long time ago. Can you hereby agree to the new CLA:

• You will only submit contributions where you have authored 100% of the content.
• You will only submit contributions to which you have the necessary rights. This means in particular, that if you are employed you have received the necessary permissions from your employer to make the contributions.
• Whatever content you contribute will be provided under the project license(s) (see "LICENSE.txt")

Thank you very much again for your PR :-)

[barancev]

Yes, I confirm I agree to this CLA.

[aaschmid]

Thanks :-)