backport scheming draft_fields_required=false support

[wardi]

backport of ckan#8309 to work with ckan/ckanext-scheming#418

[twdbben]

Thanks for this, Ian. I will have an opportunity to test this once I complete work on our upgrade to 2.10, hopefully early next week.

[twdbben]

I have not had the opportunity to run this code locally yet but it looks good to me based on visual inspection.

[twdbben]

@wardi Per my demo in the tech talk meeting you attended on Wednesday, my attempt at using this is having an issue when creating a new dataset. I'll describe what I think are the relevant details here.

• ckanext-twdh_theme is not turned on, so it is not causing conflicts

• Our dataset.yaml defines a field on dataset form page 2 called collection_method, which is set to true.

• When I fill out the fields on dataset form page 1 for a new dataset and click 'Next', the form comes back with 'Collection Method: Missing value'

• However, in the background the dataset has been created. If I go to my profile page, the new dataset shows, and is marked as 'Draft'.

• If I then click on the new dataset from the profile and go on to edit it, clicking 'Next' from form page 1 correctly takes me to form page 2 without the error.

• If on form page 2 I click 'Next' without completing the required collection_method field, it works as expected.

• If I 'Next', 'Next', 'Next' all of the way through the form and try to 'Finish' at the end without having completed the collection_method field, it correctly gives me the 'Collection Method: Missing value' error.

• If I go back and set the collection_method field and then try to 'Finish', it correctly finishes the dataset

• All of which is to say, everything seems to be working except for the 'Next' button on form page 1 incorrectly throwing the error on the required field from page 2.

Let me know if there is anything I can try on my end, or if I can clarify any of the above.

[wardi]

@twdbben the schema is 404 for me, is there another link?

[twdbben]

@twdbben the schema is 404 for me, is there another link?

It's a private repo so I needed to give you access, which I have done.

[wardi]

@twdbben the invite link has expired, would you send another?

[twdbben]

@twdbben the invite link has expired, would you send another?

Sent!