Update for #264 [TPROC-H] MySQL create FKs after table load. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianricci
pushed a commit
to christianricci/HammerDB
that referenced
this pull request
Sep 7, 2021
…se (#1) * Fix invalid sslmode value for Transaction Counter * Fix can't read sslmode value when using asynchronous scaling * Fix wrong number of args with sslmode for TPROC-H Refresh Function * Add sslmode to XML config for PostgreSQL connect pool * Add PostgreSQL sslmode option to GUI interface for TPROC-C/H and TX Counter * Fix sslmode for TPROC-C Asynch with Connect Pool
|
Accepting pull request as voted on September 7, 2021 in the TPC-OSS subcommittee. |
sm-shaw
added a commit
that referenced
this pull request
Sep 14, 2021
* Add sslmode support for PostgreSQL database Allow pg_sslmode argument to be passed into the postgres driver. Keep default argument value to prefer to make it compatible with default postgres value (refer to https://www.postgresql.org/docs/13/libpq-ssl.html) pg_sslmode can be changed as follows: hammerdb>dbset db pg Database set to PostgreSQL hammerdb>print dict Dictionary Settings for PostgreSQL connection { pg_host = localhost pg_port = 5432 pg_sslmode = prefer } ... hammerdb>diset connection pg_sslmode disable Changed connection:pg_sslmode from prefer to disable for PostgreSQL hammerdb>print dict Dictionary Settings for PostgreSQL connection { pg_host = localhost pg_port = 5432 pg_sslmode = disable } ... All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc. * Updates for #274 add sslmode support for PostgreSQL database (#1) * Fix invalid sslmode value for Transaction Counter * Fix can't read sslmode value when using asynchronous scaling * Fix wrong number of args with sslmode for TPROC-H Refresh Function * Add sslmode to XML config for PostgreSQL connect pool * Add PostgreSQL sslmode option to GUI interface for TPROC-C/H and TX Counter * Fix sslmode for TPROC-C Asynch with Connect Pool Co-authored-by: Steve Shaw <38044085+sm-shaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates after tests for Issue #264 - creating foreign keys after table load did not prove effective, however investigation showed that existing indexes were not compatible with TPC-H specification and therefore build updated for compliance. Default storage engine changed to innodb as updated configuration performed better than previous default myisam. Updates for both MySQL and MariaDB.
Test scripts attached to Issue #264 - potential to revisit configuration and build if MySQL/MariaDB supports features such as parallel index builds and/or parallel query in the future.