Make Linux hammerdb executable work with spaces in PATH #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the $PATH variable contained spaces then it would result in an error like this: ``` ./hammerdb: 6: export: (x86)/Microsoft: bad variable name ``` By double quoting the usage of the existing $PATH variable bash handles this correctly.
JelteF
force-pushed
the
fix-hammerdb-with-spaces-in-path
branch
from
034a8be
to
9f1e9e6
Compare
|
I have tested and confirmed that the error "bad variable name" is received if there are spaces already in the PATH environment variable, and this is resolved by double-quoting. I have also tested on Windows to verify there is no impact. |
|
Merging Pull Request as voted on by TPC-OSS subcommittee on 11th Jan 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the $PATH variable contained spaces then it would result in an error
like this:
By double quoting the usage of the existing $PATH variable bash handles
this correctly.