Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL Server encrypt connection and trust certificate #406

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

sm-shaw
Copy link
Contributor

@sm-shaw sm-shaw commented Aug 9, 2022

Adds encrypt connection and trust certificate options as per issue #390
Pull request also fixes #405 by reversing indentation in area where search is done for script option insertions

encrypt

@sm-shaw
Copy link
Contributor Author

sm-shaw commented Aug 9, 2022

Also, to note that it was verified that encrypt connection has the intended effect, only unencrypted connection below was from SSMS to run the query.

SELECT  session_id,encrypt_option
FROM    sys.dm_exec_connections

session_id	encrypt_option
51	FALSE
52	TRUE
53	TRUE
58	TRUE
55	TRUE
64	TRUE
61	TRUE
60	TRUE
57	TRUE
62	TRUE
63	TRUE
65	TRUE
66	TRUE
67	TRUE
68	TRUE
69	TRUE
70	TRUE
71	TRUE
72	TRUE
73	TRUE
74	TRUE
75	TRUE
76	TRUE
77	TRUE
78	TRUE
79	TRUE
80	TRUE
81	TRUE
83	TRUE
82	TRUE
84	TRUE
85	TRUE
86	TRUE
87	TRUE
88	TRUE
89	TRUE
90	TRUE
91	TRUE
93	TRUE
92	TRUE
94	TRUE
95	TRUE
96	TRUE
97	TRUE
98	TRUE
99	TRUE
100	TRUE
101	TRUE
102	TRUE
103	TRUE
104	TRUE
105	TRUE
106	TRUE
107	TRUE
108	TRUE
109	TRUE
110	TRUE
111	TRUE
112	TRUE
113	TRUE
114	TRUE
115	TRUE
116	TRUE
118	TRUE
117	TRUE
119	TRUE
120	TRUE
121	TRUE
123	TRUE
122	TRUE
124	TRUE
125	TRUE
126	TRUE
128	TRUE
127	TRUE
130	TRUE
129	TRUE
131	TRUE
132	TRUE
133	TRUE
134	TRUE
135	TRUE
136	TRUE
138	TRUE
137	TRUE
139	TRUE
140	TRUE
141	TRUE
142	TRUE
143	TRUE
144	TRUE
145	TRUE
146	TRUE
147	TRUE
149	TRUE
148	TRUE
150	TRUE
152	TRUE
151	TRUE
154	TRUE
153	TRUE
156	TRUE
155	TRUE
157	TRUE
158	TRUE

@sm-shaw
Copy link
Contributor Author

sm-shaw commented Aug 16, 2022

Merging Pull Request as approved by TPC-OSS Code maintenance team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants