-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker 4.7 #524
Docker 4.7 #524
Conversation
Updated UnixODBC 2.3.9 to 2.3.11 and ODBC Driver 17 to 18 for MSSQL Server
Can follow the issue TPC-Council#497
…il#506 Updated generic Readme with more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default version of python has changed in Ubuntu but not in HammerDB built on 20.04.
# ./hammerdbcli py
HammerDB CLI v4.7
Copyright (C) 2003-2023 Steve Shaw
Type "help()" for a list of commands
Error: Python version 3.8 required, version 3.10.6 is installed
This should be changed to install version 3.8 instead.
#Install Python3.8
RUN apt install -y python3
Is it possible to distinguish the image name of database specific dockerfiles from the one that includes all databases? This way they could be installed side by side.
Can we change the main readme file and database specific readmes in the directories to be named Readme.md and updated in markdown format. An example from the main HammerDB readme is shown below. This way it will be more readable when browsing the files from GitHub.
--
HammerDB
HammerDB is the leading benchmarking and load testing software for the worlds most popular databases supporting Oracle Database, Microsoft SQL Server, IBM Db2, PostgreSQL, MySQL and MariaDB.
Credits
- Steve Shaw
- All Contributors
License
GNU General Public License v3.0. Please see License File for more information.
Support
Thanks for the review.
I have all database specific images built this way:
Alternatively, if you meant, if we could have database specific Dockerfile names as below so all are placed under one directory, that's doable too.
Thanks, |
Updated the file in markdown format.
Added Instructions to find Database specific Dockerfiles.
HammerDB 4.7 requires Python3.8.10 Whereas ubuntu 22.04 supports Python3.8.16
For the requested changes:
|
Thank-you for the changes and the explanation about building the different lightweight images. I have retested by doing a build, this all looks great, and I have approved. |
Approving with two reviews until Code Maintenance Team expands back to three members |
Updated Dockerfile to build HammerDB 4.7
Updated the Ubuntu image to be used to 22.04 from 20.04
Modified the Docker image entry point command to support Kubernetes. #495
Updated MSSQL Client libraries #496
Added GUI support to the Dockerfile #497
Added Database specific Dockerfiles to maintain lightweight containers. #506
Deleted explicit addition of example scripts, now that they are part of HammerDB 4.7 bundle #509
Updated Readme to reflect the latest changes.