-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quotemeta function to escape special characters in passwords #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 19, 2024
jamiere-msft
approved these changes
Jan 19, 2024
abondvt89
approved these changes
Jan 19, 2024
Merging after reviews and approval of the three members of the code maintenance team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function based on perl quotemeta https://perldoc.perl.org/functions/quotemeta to escape special characters such as semicolon or brackets in passwords.
Behaviour is optional with new generic setting of quote_passwords with default of true but if set to false then behaviour will be as previous.
Depending on the interface some additional manual quoting will be needed as follows:
At this PR we do not plan to support the change for XML connect pool as this requires further work to escape the characters for the XML parser.
At the present time the change is designed to be as the least intrusive as possible, especially where special characters are not used in passwords and allow for users who to prefer wrapping passwords to still do so, whereas it will pick up obvious uses and prevent the scripts erroring due to special characters.