Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fallback when building python API #126

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Conversation

q-posev
Copy link
Member

@q-posev q-posev commented Jun 5, 2023

@q-posev q-posev requested a review from scemama June 5, 2023 13:42
@q-posev
Copy link
Member Author

q-posev commented Jun 6, 2023

Took advantage and fixed a few bugs, cleaned a little bit and improved the build script. Now it copies and uses config.h to build Python API when using make python-install. When building from Python dist tarball (pip install .) - it will try to detect HDF5 using env variables, so they need to be either set in advance or pkg-config will try to find HDF5 and then if both fail - use text.

I also refactored the Python tests, now they can run using pytest parametrization for both HDF5 and TEXT back ends.

@scemama scemama merged commit 81818a4 into master Jun 8, 2023
@q-posev q-posev deleted the text-fallback-python branch June 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip installation without HDF5 installed.
2 participants