Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with decommissioning units #351

Merged
merged 4 commits into from
Dec 27, 2021
Merged

Fixed issue with decommissioning units #351

merged 4 commits into from
Dec 27, 2021

Conversation

dweinerATL
Copy link
Contributor

@dweinerATL dweinerATL commented Dec 27, 2021 •
edited
Loading

cinnion
cinnion reviewed Dec 27, 2021
View reviewed changes
app/Chapter.php Outdated
* @return mixed
*/
public function getNumActiveChildren(string $id = null) {
if (empty($id) === true) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent level of 2 rather than 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cinnion Fixed

cinnion
cinnion reviewed Dec 27, 2021
View reviewed changes
app/Chapter.php Outdated
*
* @return mixed
*/
public function getNumActiveChildren(string $id = null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace should be on a line of its own.

@dweinerATL dweinerATL merged commit 8ce60f0 into master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinnion cinnion cinnion approved these changes

@dbuckalew dbuckalew dbuckalew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweinerATL @dbuckalew @cinnion