getAssignedShip modification #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getAssignedShip from app/User.php:534 was modified to read a list of chapter types from the config values in the database instead of a coded list. This allows members of new types of chapters to view their chapter roster. CHANGELOG.md was updated to reflect this change as well as the previous two minor changes.
dweinerATL
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
@dbuckalew don't forget to add the new config to prod and dev before it's deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified getAssignedShip to pull values from the config rather than use hardcoded values as part of getting Civilian chapters online.