Fix use of array reduce without initial value

TRUEPIC · Aug 1, 2019 · 39e834f · 39e834f
1 parent 5e57821
commit 39e834f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/src/parsers/base.js b/src/parsers/base.js
@@ -35,13 +35,9 @@ class BaseParser {
   }
 
   buildValidationError(error) {
-    const detail = error.details.reduce((mostSpecific, detail) => {
-      if (mostSpecific && mostSpecific.path.length >= detail.path.length) {
-        return mostSpecific
-      }
-
-      return detail
-    })
+    const detail = error.details.reduce((mostSpecific, detail) =>
+      mostSpecific.path.length >= detail.path.length ? mostSpecific : detail
+    )
 
     const path = detail.path.reduce(
       (accumulator, value, index) =>

diff --git a/src/validators/joi.js b/src/validators/joi.js
@@ -8,13 +8,9 @@ class JoiValidator extends BaseValidator {
   }
 
   buildError(error) {
-    const detail = error.details.reduce((mostSpecific, detail) => {
-      if (mostSpecific && mostSpecific.path.length >= detail.path.length) {
-        return mostSpecific
-      }
-
-      return detail
-    })
+    const detail = error.details.reduce((mostSpecific, detail) =>
+      mostSpecific.path.length >= detail.path.length ? mostSpecific : detail
+    )
 
     const path = detail.path.reduce(
       (accumulator, value, index) =>