Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncaught exception in main.js - Cannot read property 'webContents' of null #395

Closed
araujoarthur0 opened this issue Oct 2, 2020 · 0 comments · Fixed by #397
Closed

uncaught exception in main.js - Cannot read property 'webContents' of null #395

araujoarthur0 opened this issue Oct 2, 2020 · 0 comments · Fixed by #397
Assignees
@araujoarthur0
Labels
bug Something isn't working

Comments

@araujoarthur0
Copy link
Collaborator

Describe the issue
A crash in main.js on an idle TTL window:

Fri, 02 Oct 2020 13:12:37 GMT uncaughtException: Cannot read property 'webContents' of null TypeError: Cannot read property 'webContents' of null at Timeout.refreshOnDayChange [as _onTimeout] (C:\Users\araujo\Documents\workspace\time-to-leave\main.js:41:20) at listOnTimeout (internal/timers.js:531:17) at processTimers (internal/timers.js:475:7)

Apparently mainWindow can be null at this stage. Other usages of the variable in main.js always check if it's not null before using it, while this one doesn't. The fix should be to add an if guard.

Expected behavior
No crashes.
@araujoarthur0 araujoarthur0 added the bug Something isn't working label Oct 2, 2020
@araujoarthur0 araujoarthur0 self-assigned this Oct 2, 2020
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 2, 2020
@araujoarthur0
TTLApp#395: Fixing uncaught exception in main.js on day refresh
bb7f174
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 2, 2020
@araujoarthur0
Fix TTLApp#395: Fixing uncaught exception in main.js on day refresh
c3ee394
@araujoarthur0 araujoarthur0 mentioned this issue Oct 2, 2020
Merged
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 3, 2020
@araujoarthur0
Fix TTLApp#395: Fixing uncaught exception in main.js on day refresh
648c8aa
araujoarthur0 added a commit to araujoarthur0/time-to-leave that referenced this issue Oct 3, 2020
@araujoarthur0
Fix TTLApp#395: Fixing uncaught exception in main.js on day refresh
8d1f758
thamara pushed a commit that referenced this issue Oct 3, 2020
@araujoarthur0
Fix #395: Fixing uncaught exception in main.js on day refresh (#397)
3e786e5
@snyk-bot snyk-bot mentioned this issue Feb 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@araujoarthur0 araujoarthur0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #395: Fixing uncaught exception in main.js on day refresh araujoarthur0/time-to-leave
1 participant
@araujoarthur0