Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion issue to decide on the future of fixed vs flexible #401

Closed
araujoarthur0 opened this issue Oct 3, 2020 · 1 comment · Fixed by #541
Closed

Discussion issue to decide on the future of fixed vs flexible #401

araujoarthur0 opened this issue Oct 3, 2020 · 1 comment · Fixed by #541
Assignees
Labels
question Further information is requested

Comments

@araujoarthur0
Copy link
Collaborator

Just to document that we have this issue in place and it needs to be finalized before the next release happens.

If we go for flexible only:

  • Remove number-of-entries preferences
  • Remove class duplication, and simplify styles

If we keep them:

  • Separate styles file ASAP, we're over 1200 lines
  • Rename Calendar to FixedMonthCalendar and create a base calendar class with stub method implementations
@araujoarthur0 araujoarthur0 added the question Further information is requested label Oct 3, 2020
@thamara
Copy link
Collaborator

thamara commented Oct 8, 2020

I think we should go for flexible always, do these things you mentioned, but have a better error handling if someone has any type of issue migrating to the flexible.
The reasons for migrating to the flexible:

  • It doesn't remove any feature from the user
  • It will allow us to only need to maintain one calendar type
  • It will allow us to implement a partial waiver (as now we are not tied to 2 or entries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants