-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flexible day calendar #379
Conversation
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 55.21% 56.72% +1.51%
==========================================
Files 24 25 +1
Lines 2063 2373 +310
Branches 348 401 +53
==========================================
+ Hits 1139 1346 +207
- Misses 818 908 +90
- Partials 106 119 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comment regarding the alignment of the content in the day view and the reuse of the API for formating the key, I think the PR is in pretty good shape.
I see a lot of code that is duplicated from the fixed calendar, but I think we most likely we'll replace completely the fixed one, so it should not be a problem.
Once this PR is done, I think we need to discuss a bit on the future of TTL w.r.t. the fixed vs flexible DBs.
Yeah, I decided to copy styles and functions instead of reusing them from the other day calendar because we're still discussing that. |
19d84ce
to
0a09a37
Compare
Using generateKey, updated documentations to fit my other PR and alignment fix. |
Related issue
Closes #369
Context / Background
This PR introduces a Day Calendar with a flexible number of entries :)
What change is being introduced by this PR?
New button on Flexible Month Calendar to switch to Day Calendar
Changes on preferences to allow flexible + day
New FlexibleDayCalendar class built in the same idea of the FixedDayCalendar, but with the structure of FlexibleMonthCalendar
Entry pairs are added on new rows in the table, with intervals between them
To add an entry there is a button near the day total box
To remove the last entry there is a dialog to confirm removal (button appears when there are more than 2 pairs of entries)
Input errors color the entry row with the error
How will this be tested?
New tests were added following the idea of the other Calendar tests.