Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving coverage for auxiliary functions in calendar #204

Closed
wants to merge 6 commits into from

Conversation

thamara
Copy link
Collaborator

@thamara thamara commented Apr 10, 2020

Improving coverage for auxiliary functions in calendar

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #204 into master will increase coverage by 3.83%.
The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   22.07%   25.91%   +3.83%     
==========================================
  Files          11       12       +1     
  Lines         915      930      +15     
  Branches      170      177       +7     
==========================================
+ Hits          202      241      +39     
+ Misses        614      594      -20     
+ Partials       99       95       -4     
Impacted Files Coverage Δ
js/calendar.js 0.00% <0.00%> (ø)
main.js 0.00% <0.00%> (ø)
js/calendar-aux.js 100.00% <100.00%> (ø)
js/import-export.js 100.00% <100.00%> (ø)
js/workday-waiver-aux.js 75.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046de69...8241c8e. Read the comment docs.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a ton of rebasing with @araujoarthur0 's recent changes.

@thamara
Copy link
Collaborator Author

thamara commented May 18, 2020

Yeah. I've been putting it off for a while as it will be probably easy to do it all over again.

@thamara thamara closed this Jun 22, 2020
@thamara thamara deleted the coverage-calendar-aux branch June 22, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants