Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Layout #377

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Fixed Layout #377

merged 3 commits into from
Oct 1, 2020

Conversation

divyamtayal
Copy link
Contributor

Related issue

Closes #300

Context / Background

Fixed the layout which was broken when width<770px (actually it was <768px)

What change is being introduced by this PR?

.container class by automatically was keeping max-width:540px below width:768px, so I fixed it by adding a media query for width <768px and made max-width remains same as it was for width>768px

How will this be tested?

BEFORE(width<=768px)

Screenshot 2020-10-01 020713
AFTER (width<=768px)

Screenshot 2020-10-01 020832

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #377 into main will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   57.96%   57.86%   -0.10%     
==========================================
  Files          23       23              
  Lines        2046     2046              
  Branches      344      344              
==========================================
- Hits         1186     1184       -2     
- Misses        761      762       +1     
- Partials       99      100       +1     
Impacted Files Coverage Δ
js/classes/Calendar.js 73.60% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9221c1c...f2f90b4. Read the comment docs.

@divyamtayal divyamtayal changed the title Fix 300 Fixed Layout Sep 30, 2020
Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks great! Thank you :D
Can you please update the changelog.md file to include this fix, as well as include your user on Who build 1.5.6?

Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@thamara thamara merged commit d4d1270 into TTLApp:main Oct 1, 2020
@thamara
Copy link
Collaborator

thamara commented Oct 1, 2020

@daretobedifferent18 congratulations on your first merged PR on TTL!

Here's to many more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout broken when width < 770px
2 participants