Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the content Select input of preferences window on the right. #417

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

sajeevan16
Copy link
Contributor

@sajeevan16 sajeevan16 commented Oct 7, 2020

Related issue

Closes #414

Context / Background

2020-10-07_12h35_08

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #417 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main     #417     +/-   ##
=========================================
  Coverage   58.62%   58.62%             
=========================================
  Files          25       50     +25     
  Lines        2429     4858   +2429     
  Branches      385      770    +385     
=========================================
+ Hits         1424     2848   +1424     
- Misses        893     1786    +893     
- Partials      112      224    +112     
Impacted Files Coverage Δ
...me-to-leave/time-to-leave/js/workday-waiver-aux.js 75.00% <0.00%> (ø)
D:/a/time-to-leave/time-to-leave/js/menus.js 0.00% <0.00%> (ø)
...ime-to-leave/time-to-leave/js/date-db-formatter.js 100.00% <0.00%> (ø)
D:/a/time-to-leave/time-to-leave/main.js 0.00% <0.00%> (ø)
...:/a/time-to-leave/time-to-leave/src/preferences.js 0.00% <0.00%> (ø)
...-leave/time-to-leave/js/classes/CalendarFactory.js 67.34% <0.00%> (ø)
D:/a/time-to-leave/time-to-leave/js/windows.js 0.00% <0.00%> (ø)
...time-to-leave/time-to-leave/js/classes/Calendar.js 73.75% <0.00%> (ø)
...time-to-leave/time-to-leave/js/user-preferences.js 95.40% <0.00%> (ø)
.../a/time-to-leave/time-to-leave/js/import-export.js 98.13% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24f57d...f8afeed. Read the comment docs.

Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the trailing space, everything looks great!

css/styles.css Outdated Show resolved Hide resolved
@thamara
Copy link
Collaborator

thamara commented Oct 8, 2020

\changelog-update
Message: Enhancement: [#414] Right-align content of selection boxes from Preferences Window
User: sajeevan16

@thamara thamara merged commit 116b289 into TTLApp:main Oct 8, 2020
@thamara
Copy link
Collaborator

thamara commented Oct 8, 2020

Thank you @sajeevan16 for your contribution! Hope to see you around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu options on Preference Windows should be right aligned
2 participants