-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Preferences" styling #563
Conversation
fixes. Done in this commit: - added `@fortawsome/fontawsome-free` package to `package.json` - changed positions of options in preferences - fixed switch vertical position, by setting margin-top, margin-bottom to 'auto' in `style.css` - aligned work hours input to the right - added styles and code to icons in Preferneces window - resolve to #557 - improved grouping in Preferences
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 71.54% 71.54%
=======================================
Files 28 28
Lines 2583 2583
Branches 391 391
=======================================
Hits 1848 1848
Misses 656 656
Partials 79 79 Continue to review full report at Codecov.
|
@thamara, can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good with the icons and the sections! Loved it!
Co-authored-by: Thamara Andrade <tkcandrade@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
\changelog-update |
Thanks! |
Done in this commit:
@fortawsome/fontawsome-free
package topackage.json
'auto' in
style.css
preferences.html
, changingRelated issue
Closes #557
Showcase
Before
After