Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Preferences" styling #563

Merged
merged 4 commits into from
Oct 29, 2020
Merged

"Preferences" styling #563

merged 4 commits into from
Oct 29, 2020

Conversation

saviusz
Copy link
Contributor

@saviusz saviusz commented Oct 27, 2020

Done in this commit:

  • added @fortawsome/fontawsome-free package to package.json
  • changed positions of options in preferences
  • fixed switch vertical position, by setting margin-top, margin-bottom to
    'auto' in style.css
  • aligned work hours input to the right
  • added styles and code to icons in Preferences window - resolve to International title of "Language" option in preferences #557
  • improved grouping in Preferences
  • Modified structure of preferences.html, changing
       <div class="flex-box">
          <p {jQuery tag}>{Name}</p>
       </div>
    to
       <div class="flex-box">
          <p>
            <i class="fas fa-icon"></i>
            <span {jQuery tag}>{Name}</span>
          </p>
       </div>

Related issue

Closes #557

Showcase

Before


After

fixes.

Done in this commit:
- added `@fortawsome/fontawsome-free` package to `package.json`
- changed positions of options in preferences
- fixed switch vertical position, by setting margin-top, margin-bottom to
  'auto' in `style.css`
- aligned work hours input to the right
- added styles and code to icons in Preferneces window - resolve to #557
- improved grouping in Preferences
@saviusz saviusz changed the title Added "Font Awsome" package, added icons to "Preferences window", small fixes. "Preferences" styling Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #563 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   71.54%   71.54%           
=======================================
  Files          28       28           
  Lines        2583     2583           
  Branches      391      391           
=======================================
  Hits         1848     1848           
  Misses        656      656           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28f747...b6bcd6f. Read the comment docs.

@saviusz
Copy link
Contributor Author

saviusz commented Oct 27, 2020

@thamara, can you review this?

Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good with the icons and the sections! Loved it!

css/styles.css Outdated Show resolved Hide resolved
src/preferences.html Outdated Show resolved Hide resolved
src/preferences.html Show resolved Hide resolved
src/preferences.html Show resolved Hide resolved
saviusz and others added 3 commits October 27, 2020 23:26
Co-authored-by: Thamara Andrade <tkcandrade@gmail.com>
Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thamara
Copy link
Collaborator

thamara commented Oct 29, 2020

\changelog-update
Message: Enhancement: [#563] Making the preferences window more organized and pretty
User: SaviPrograms

@thamara thamara merged commit 635b858 into TTLApp:main Oct 29, 2020
@thamara
Copy link
Collaborator

thamara commented Oct 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

International title of "Language" option in preferences
2 participants