Remove button moved to left side of Workday Waiver List #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 27 27
Lines 2107 2107
Branches 295 295
=======================================
Hits 1461 1461
Misses 579 579
Partials 67 67
Continue to review full report at Codecov.
|
jrasmith0
changed the title
tupaschoal
reviewed
Nov 27, 2020
Before changes made:
After changes made:
|
|
The screenshots look the same, don't they? |
You're right, dragging uploaded two copies of the same file, uploaded the correct file under before changes. |
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#445
Context / Background
Move delete button from the right hand side labeled column to left hand side non-labeled column of the Workday Waiver List
What change is being introduced by this PR?
Removed data value associated with labeling the table header for the delete category and reordered the associated cells under the generation of the subsequent data rows. This results in an unnamed header for the delete category as well as the functional operation of the delete buttons on the left hand side of the table.
How will this be tested?
Tested locally by running the application, ensuring the the functionality of the operations is still the same. Test cases cleared.