Radar move from shop UI #1624
Draft
Radar move from shop UI #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
reviewed
Sep 22, 2024
| SWEP.Secondary.Delay = 1.0 | ||
|
|
||
| SWEP.Kind = WEAPON_EQUIP2 | ||
| SWEP.CanBuy = { ROLE_TRAITOR, ROLE_DETECTIVE } -- only traitors can buy |
There was a problem hiding this comment.
Suggested change
| SWEP.CanBuy = { ROLE_TRAITOR, ROLE_DETECTIVE } -- only traitors can buy | |
| SWEP.CanBuy = { ROLE_TRAITOR, ROLE_DETECTIVE } |
| SWEP.Kind = WEAPON_EQUIP2 | ||
| SWEP.CanBuy = { ROLE_TRAITOR, ROLE_DETECTIVE } -- only traitors can buy | ||
| SWEP.LimitedStock = true -- only buyable once | ||
| SWEP.WeaponID = EQUIP_RADAR or 2 |
There was a problem hiding this comment.
I don't think this is needed anymore
|
No, I removed that part. Seemed kinda silly. But that was at a point where I tried to unpack the radar library, so I could probably easily bring it back. Also the radar can now be dropped/conquered, so the balance of that item has changed. |
I already removed that from the marker, the necro and supervillain, because they "misused" the radar for other things, such as corpses, crystals etc. I'm not sure if any third party addons still use this, probably not I'd guess? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the radar item to a SWEP and therefore eliminates the use of the equipment tab to manually trigger the radar.
Also I cleaned up the weird RADAR class and put it into a library. It now handles only the Target rendering of the Radar and of corpses, bombs and dna samples.
In this draft missing are sounds. Also the current weapon mesh is the radio, I thought to put it in another holding position to distinguish it a bit from the radio.