-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev environment setup #2
Changes from 1 commit
94623fc
21a5623
281ea74
8c62d6f
69dde0d
d53d1ca
7a225f5
f5d9009
2c0941c
64fd37b
f48d739
eac0d50
0b9f346
7f5965a
93f800a
1eb9562
8a66b7a
2ca52b7
91d4af8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,7 @@ | |
"presets": [ | ||
"env", | ||
"react", | ||
"stage-2", | ||
"flow" | ||
"stage-2" | ||
], | ||
plugins: [ | ||
"react-hot-loader/babel" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,3 @@ | |
/public | ||
/config/** | ||
registerServiceWorker.js | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there something about service workers that eslint disagrees with? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, lines 2 and 3 are not needed anymore. The service worker is all over the place. It'm mainly so serve content offline. That is all is seems to do but that boilerplate from CRA. However, it is not styled in any way really, but i don't want to touch it since it is boilerplate from CRA |
||
/src |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,10 +111,4 @@ NavBar.propTypes = { | |
logout: PropTypes.func.isRequired, | ||
}; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the linter got mad when we had a requiredProp along with a default value. If the user was not passed, then webpack would not compile altogether, so there was no need to add a default prop value |
||
NavBar.defaultProps = { | ||
user: { | ||
name: '', | ||
}, | ||
}; | ||
|
||
export default NavBar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you typically have to pass some configuration options to
env
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Works out of the box