Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Get rid of hard coded opening hours #491

Closed
kordianbruck opened this issue Jun 28, 2017 · 7 comments · Fixed by #1281
Closed

Get rid of hard coded opening hours #491

kordianbruck opened this issue Jun 28, 2017 · 7 comments · Fixed by #1281

Comments

@kordianbruck
Copy link
Member

Currently all opening hours are hardcoded inside the locations.csv - this is really bad.

Need to implement an API endpoint and redo the manager.

@arisun
Copy link

arisun commented Jul 6, 2017

Hi I would like to contribute on this issue. Is the issue still open ?

@kordianbruck
Copy link
Member Author

@arisun yes! We still have that ugly CSV in the assets folder.

We would love to have it replaced by a API method on our server. Should I set this up for you?

@zepatrik
Copy link
Contributor

Someone working on this should also add the possibility to have separate opening hours during the semester and during the semester break.

@jacqueline8711
Copy link
Member

@i-walker Are you still planning on implementing this? The first step being the usage of the endpoint https://app.tum.de/Api/openingtimes

@kordianbruck
Copy link
Member Author

@jacqueline8711 I think he is currently traveling, but will be back by the end of the week. Let us give him some more time.

@i-walker
Copy link

Can someone help me with the Apiclient I can't find it ?

@kordianbruck
Copy link
Member Author

@jacqueline8711 feel free to go ahead with this issue and / or the already started PR. Unfortunately, we did not get the second position. So its up to you ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants