Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Get Opening Hours from Server #1281

Merged
merged 6 commits into from
Apr 21, 2019
Merged

Conversation

jacqueline8711
Copy link
Member

@jacqueline8711 jacqueline8711 commented Apr 8, 2019

Issue

Fixes #491 , Fixes #1225

Screenshot

Screenshot_20190408-205258 (2)
Screenshot_20190408-211111 (1)

Why this is useful for all students

we can update the opening hours at all times so the user will have more accurate opening hours

@jacqueline8711 jacqueline8711 requested review from kordianbruck, thellmund and pfent and removed request for kordianbruck April 8, 2019 19:17
var hours: String = "",
@SerializedName("infos")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you did not change anything with any database model except this, so a migration is not needed right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no migration is needed

Copy link
Member

@kordianbruck kordianbruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you are sure we don't need any migrations, feel free to merge :)

@jacqueline8711 jacqueline8711 merged commit ce242f3 into master Apr 21, 2019
@jacqueline8711 jacqueline8711 deleted the jacqueline/opening-hours branch April 21, 2019 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening Times Cafeteria wrong Get rid of hard coded opening hours
2 participants