-
-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
Search should be done. Here it the final look of it: DiscussionIf anyone has other suggestions on what more can be done here, I am open to adding them.
|
I tested your code and everything works as expected. Just one small issue I noticed: From a performance perspective for Seach-as-you-type: @joschahenningsen what can our current backend handle? |
I have no worries, backend wise here :) |
Just to make shure, that there has not been a miscomunication. |
Right that should be no issue |
I have added search-as-you-type. The enter key still does not run the search, but now with search-as-you-type, I think it is not needed. |
Issue
Fixes: #678
Description
More or less I want to create a centralized search, that was started in #1343 PR. Why am I doing it from scratch instead of using a branch from existing PR? Since this code was created 3 years ago I had a hard time merging it with the current master; there were too many conflicts. Therefore, I decided to start over again.
Additional to what was proposed in #1343 PR I am thinking of adding the history of searches, and maybe some tags (lecture, person, room, ...) for quicker navigation in search results.