Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Feature/improve news #446

Merged
merged 5 commits into from
Jun 5, 2022
Merged

Feature/improve news #446

merged 5 commits into from
Jun 5, 2022

Conversation

14slash12
Copy link
Contributor

Issue

  1. The NewsView was loading very long; scrolling on the news view was very laggy – Could be fixed because all NewsCards were loaded with height = 0 if the Collapsible is closed. This was changed by using an if-block -> NewsCard will only be loading when the Collapsible is open.
  2. Small issues: Sorting of the news was from oldest to newest; design inconsitencies (e.g. the arrow of an Collapsible)
  3. Additionally: Only loading the newest 5 news per news source; added a button to the ScrollView to load the next 5 news)

This fixes the following issue(s):
#444

Screenshots
Screenshot 2022-06-04 at 09 41 38

@14slash12 14slash12 requested review from mvitanov and AW-tum June 4, 2022 07:45
@14slash12 14slash12 self-assigned this Jun 4, 2022
@AW-tum AW-tum merged commit 4e2f963 into swiftui Jun 5, 2022
@AW-tum AW-tum deleted the feature/improve-news branch June 5, 2022 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants