This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Gias/search view #540
Merged
Gias/search view #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws to display the results from the query the user entered, but always going back to the HomeView/WidgetView by canceling the search.
…entataion of how likely the category/data type was searched for
…algorithm to search across all properties of each grade
…documentation with DocC. Refactoring the UI.
…g each result by data type and the heighest match, i.e. if a grade has the best levensheit distance all grades are displayed first
…esult is sorted by the ML
…toring into multiple files to have a better overview
…hing levenshtein distance, but rather each one by ascending order. E.g. GradeA has for token ['grade','ott'] the two best levenshtein distances of [0, 71] and GradeB has [0, 78] -> GradeA is better than GradeB.
… struct EventSearchResult and creating a new CalendarService for API fetches
…exists) Additionally, the algorithm for calculating the bestRelativeLevenshteinDistance was changed to the normalized Levenshtein Distance (see https://ieeexplore.ieee.org/document/4160958)
… were previously not shown, i.e. the onChange(for:query) in each view did not get trigged. So each SearchResultView gets a onAppear to trigger the searching in each View even if the View was previously not on the screen, but now is due to a change in the query. 2) Added the RoomFinder and the LectureSearch to the GIAS
…ne MainAPI enum independent of the API (TUMCabe, TUMOnline, CampusOnline, etc.), the respective data type which (i.e. Grades, Movie, StudyRoom, etc.) and independent of the decoder (XML or JSON).
…o be used with the newly created method makeRequest<T,S> in the enum MainAPI
…um and the new API. This includes, that Calendar now shows the error screen, if the fetching failed
…t-pattern with the state enum
…tern and error handling for this view.
… to the async-await-pattern, and the state-enum and handling errors properly
… API and to work with asnc-await
… new API, including async-await pattern and many many adjustments alongside.
…lineAPI/CampusOnlineAPI completely.
…-handling, state-enum
… splitting News and Movies into custom Views/ViewModels
14slash12
requested review from
Antonwy,
philippzagar,
timothymaxwellsummers and
AW-tum
Merged
…es; See Pull Request 539
…e with the flickering MenuView due to too many async calls when fetching the DishesLabels; Old Roomfinder is in this commit still used for GIAS (Global In-App Search)
…en was invalid then the token is activated. A forced refresh is necessary to retrieve the current token activation status
Antonwy
suggested changes
May 5, 2023
There was a problem hiding this comment.
Most essential points
- For consistent mock/preview data, use either an external JSON or Swift file.
- Utilise custom ViewModifiers or Decorators to enhance your views.
- Enum
failedstate vshasStatevariable → are both necessary?
Other than that, looks really good!
→ It would be helpful if someone else could review this pull request as well, as I am not that familiar with the codebase.
Campus-iOS/MapComponent/Types/StudyRooms/StudyRoomApiResponse.swift
Outdated
Show resolved
Hide resolved
Campus-iOS/SearchComponent/ViewModels/Searchable ViewModels/GradeSearchResultViewModel.swift
Outdated
Show resolved
Hide resolved
Campus-iOS/SearchComponent/Views/SearchResultViews/Movie/MovieSearchResultView.swift
Outdated
Show resolved
Hide resolved
Antonwy
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First the GIAS/API branch needs to be merged into development which can be done with pull request #536. ✅ The design is subject to change - functionality is final.
Issue
Implements a the new GIAS (Global In-App Search) across all the data types. This includes a new view containing all the searchable types like Grades, Movies, etc. This includes some refactoring of some ViewModels and Views to make the integration possible.
Screenshots