Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:cached grpc #95

Merged
merged 8 commits into from
Oct 16, 2023
Merged

feat:cached grpc #95

merged 8 commits into from
Oct 16, 2023

Conversation

CommanderStorm
Copy link
Member

Added the ability to cache requests

jakobkoerber
jakobkoerber requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jakobkoerber jakobkoerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some things to fix/clear up ^^

lib/main.dart Outdated Show resolved Hide resolved
lib/base/networking/apis/tumdev/cached_client.dart Outdated Show resolved Hide resolved
lib/base/networking/apis/tumdev/cached_client.dart Outdated Show resolved Hide resolved
lib/base/networking/apis/tumdev/cached_client.dart Outdated Show resolved Hide resolved
@jakobkoerber
Copy link
Member

jakobkoerber commented Oct 15, 2023 •
edited
Loading

Open Issues:

  • Client still calls Endpoint despite getting Data from Cache

  • figure out if skipping of request is possible

@jakobkoerber jakobkoerber marked this pull request as ready for review October 16, 2023 11:04
@jakobkoerber jakobkoerber self-requested a review October 16, 2023 11:05
@jakobkoerber jakobkoerber merged commit 07ce6e2 into feat/grpc Oct 16, 2023
@jakobkoerber jakobkoerber deleted the feat/cached_grpc branch October 16, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobkoerber jakobkoerber jakobkoerber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @jakobkoerber