Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TUM-Live-Worker-v2 in TUM-Live #369

Merged
merged 18 commits into from
Apr 19, 2022
Merged

Include TUM-Live-Worker-v2 in TUM-Live #369

merged 18 commits into from
Apr 19, 2022

Conversation

joschahenningsen
Copy link
Member

@joschahenningsen joschahenningsen commented Apr 18, 2022 •
edited
Loading

This PR

  • Adds https://github.com/joschahenningsen/TUM-Live-Worker-v2/ as a go submodule.
  • Adds an action that builds all components of the worker as docker images when the repo is tagged
  • Adds the worker to dependabot
  • Adds a go.work file in order to resolve the worker dependencies without pushing them to GitHub first. (read more here https://go.dev/doc/tutorial/workspaces)
  • Renames the module from TUM-Live to github.com/joschahenningsen/TUM-Live to follow gos naming conventions
  • Renames the executable package to cmd/tumlive and worker/cmd/worker to follow gos naming conventions

Since I didn't change any of the code in /worker but just pasted it from the other repo, feel free to ignore it when reviewing.

closes #291

@joschahenningsen joschahenningsen added the enhancement New feature or request label Apr 18, 2022
@joschahenningsen joschahenningsen added enhancement New feature or request and removed enhancement New feature or request labels Apr 18, 2022
@joschahenningsen joschahenningsen added enhancement New feature or request and removed enhancement New feature or request labels Apr 18, 2022
@joschahenningsen joschahenningsen added enhancement New feature or request and removed enhancement New feature or request labels Apr 18, 2022
@joschahenningsen joschahenningsen marked this pull request as ready for review April 18, 2022 21:55
@joschahenningsen joschahenningsen changed the title add worker Include TUM-Live-Worker-v2 in TUM-Live Apr 18, 2022
alexanderstephan
alexanderstephan requested changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉 I just found some really minor things.

cmd/tumlive/tumlive.go Outdated Show resolved Hide resolved
cmd/tumlive/tumlive.go Outdated Show resolved Hide resolved
worker/Makefile Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
worker/edge/go.mod Outdated Show resolved Hide resolved
@joschahenningsen
Copy link
Member Author

Thanks for the input @alexanderstephan, quite a bit of refactor->rename mistakes :D Should be fixed now.

I'm still struggling to properly tidy and get go modules (golang/go#50750) but I think this should be fine for the most part once this is pushed to dev

@joschahenningsen joschahenningsen mentioned this pull request Apr 19, 2022
Closed