Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ex04.py #195

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Update ex04.py #195

merged 1 commit into from
Feb 8, 2023

Conversation

catbaron0
Copy link
Contributor

怀疑是一个typo。
从函数的功能来看应该是对 ex01.py 的扩展,沿用 world() 函数名更自然。

@TWT233
Copy link
Owner

TWT233 commented Jan 22, 2023

对的,是个typo

Copy link
Owner

@TWT233 TWT233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TWT233
Copy link
Owner

TWT233 commented Jan 22, 2023

ci没过欸 commit message有问题

@TWT233
Copy link
Owner

TWT233 commented Jan 22, 2023

这个也有commit message的问题

* fix: renmae `roll()` to `world()`

DESC: According to the functionality, the function is built by
extending `ex01.py`, thus it's more natural to use the function
`world()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants