feat: add simple ratelimit control #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWT233
requested changes
Nov 3, 2023
khl/requester.py
Outdated
| log.debug(f'{method} {route}: req: {params}') # token is excluded | ||
| if self.ratelimit: | ||
| bucket = self._ratelimit.get_bucket(route) | ||
| delay = self._ratelimit.get_delay(bucket) |
There was a problem hiding this comment.
get_delay中可以内含一个get_bucket，这样API会更好理解
There was a problem hiding this comment.
delay 是由 bucket 获取的, 不是由 route 获取的 感觉分离比较好
hank9999
force-pushed
the
ratelimit
branch
3 times, most recently
from
3a63292
to
faf2c3a
Compare
TWT233
requested changes
Nov 6, 2023
|
晚上我测测看 |
好的，麻烦老师了，我这边测试的时候能稳定住速率 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add simple ratelimit control
默认启用速率控制(剩余数量小于80时启动)，如需禁用则需要Bot传入参数ratelimiter=None
RateLimiter 支持传入参数控制什么时候开始速率控制
当剩余数量(X-Rate-Limit-Remaining) 小于 传入参数时 开始速率控制