Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Remove constructor from variable provider interface #829

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[TASK] Remove constructor from variable provider interface #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/Core/Variables/VariableProviderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,6 @@
*/
interface VariableProviderInterface extends \ArrayAccess
{
/**
* Variables, if any, with which to initialize this
* VariableProvider.
*
* @param array $variables
* @todo: This must be removed from the interface! At the moment,
* StandardVariableProvider accepts variables as constructor
* arguments, while ChainedVariableProvider expects an array
* of sub providers as constructor argument.
* Thus, setSource() should be the only way to set variables
* and StandardVariableProvider *must not* accept current
* variables as constructor argument.
* Adding variables as constructor must not be relied on!
*/
public function __construct(array $variables = []);

/**
* Gets a fresh instance of this type of VariableProvider
* and fills it with the variables passed in $variables.
Expand Down